From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] ext3: Convert ext3 to new truncate calling convention
Date: Fri, 27 May 2011 03:16:40 -0400 [thread overview]
Message-ID: <20110527071640.GA5330@infradead.org> (raw)
In-Reply-To: <20110526142337.GA5123@quack.suse.cz>
On Thu, May 26, 2011 at 04:23:37PM +0200, Jan Kara wrote:
> > This doesn't look quite correct me. One of the major points of the
> > new truncate sequence is to to *_truncate_page before updating i_size,
> > so that we can properly handle an error there. With your patch it's
> > still called too late.
> OK, I missed this point (frankly, handling of error from
> ext3_block_truncate_page() does not seem like a huge win when we cannot
> handle error anywhere else during truncate but it's an improvement I
> agree). I'll move ext3_block_truncate_page() before the setting of i_size.
> Thanks for having a look at the patch.
Btw, I think ext4 has the same issue.
next prev parent reply other threads:[~2011-05-27 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 10:43 [PATCH v2] ext3: Convert ext3 to new truncate calling convention Jan Kara
2011-05-25 11:48 ` Christoph Hellwig
2011-05-26 14:23 ` Jan Kara
2011-05-27 7:16 ` Christoph Hellwig [this message]
2011-05-25 21:41 ` Ted Ts'o
2011-05-25 21:42 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110527071640.GA5330@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.