From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: jaxboe@fusionio.com, msb@chromium.org,
linux-kernel@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH 2/3] block: Move non-rotational flag to queue limits
Date: Fri, 27 May 2011 09:02:49 -0400 [thread overview]
Message-ID: <20110527130248.GA17219@redhat.com> (raw)
In-Reply-To: <1306464169-4291-3-git-send-email-martin.petersen@oracle.com>
On Thu, May 26 2011 at 10:42pm -0400,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
> To avoid special-casing the non-rotational flag when stacking it is
> moved from the queue flags to be part of the queue limits. This allows
> us to handle it like the remaining I/O topology information.
blk_queue_nonrot vs blk_queue_non_rotational lends itself to a small
amount of confusion.
What about:
s/blk_queue_nonrot/blk_queue_non_rotational/
s/blk_queue_non_rotational/blk_queue_set_non_rotational/
?
Otherwise, looks great.
Acked-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2011-05-27 13:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 20:50 [PATCH] dm: pass up rotational flag Mandeep Singh Baines
2011-05-26 18:23 ` Mike Snitzer
2011-05-26 18:29 ` Martin K. Petersen
2011-05-26 18:43 ` Mike Snitzer
2011-05-26 18:48 ` Martin K. Petersen
2011-05-26 19:14 ` Jens Axboe
2011-05-27 2:42 ` Martin K. Petersen
2011-05-27 2:42 ` [PATCH 1/3] block: Introduce blk_set_stacking_limits function Martin K. Petersen
2011-05-27 13:03 ` Mike Snitzer
2011-05-27 2:42 ` [PATCH 2/3] block: Move non-rotational flag to queue limits Martin K. Petersen
2011-05-27 13:02 ` Mike Snitzer [this message]
2011-05-31 2:19 ` Martin K. Petersen
2011-05-31 12:49 ` Mike Snitzer
2011-05-31 13:14 ` Jens Axboe
2011-05-31 14:28 ` Martin K. Petersen
2011-05-31 14:28 ` Martin K. Petersen
2011-05-31 14:43 ` Jens Axboe
2011-05-27 2:42 ` [PATCH 3/3] block: Move discard and secure discard flags " Martin K. Petersen
2011-05-27 13:39 ` Mike Snitzer
2011-05-31 2:22 ` Martin K. Petersen
2011-07-13 15:46 ` Mike Snitzer
2011-05-27 16:20 ` Mandeep Singh Baines
2011-05-26 18:35 ` [PATCH v2] dm: pass up non-rotational flag Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110527130248.GA17219@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=msb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.