All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Bob Liu <lliubbo@gmail.com>
Cc: gerg@snapgear.com, dhowells@redhat.com, lethal@linux-sh.org,
	geert@linux-m68k.org, vapier@gentoo.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: nommu: fix remap_pfn_range()
Date: Fri, 27 May 2011 15:12:04 -0700	[thread overview]
Message-ID: <20110527151204.4e60426e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1306468203-8683-1-git-send-email-lliubbo@gmail.com>

On Fri, 27 May 2011 11:50:03 +0800
Bob Liu <lliubbo@gmail.com> wrote:

> remap_pfn_range() does not update vma->end on no mmu arch which will
> cause munmap() fail because it can't match the vma.
> 
> eg. fb_mmap() in fbmem.c will call io_remap_pfn_range() which is
> remap_pfn_range() on nommu arch, if an address is not page aligned vma->start
> will be changed in remap_pfn_range(), but neither size nor vma->end will be
> updated. Then munmap(start, len) can't find the vma to free, because it need to
> compare (start + len) with vma->end.
> 

Also, I tagged the patch (or its successor) for -stable backporting as
the problem appears to be present in 2.6.38 (at least).

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2011-05-27 22:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27  3:50 [PATCH] mm: nommu: fix remap_pfn_range() Bob Liu
2011-05-27 22:09 ` Andrew Morton
2011-06-02  6:19   ` Bob Liu
2011-05-27 22:12 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110527151204.4e60426e.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@snapgear.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-mm@kvack.org \
    --cc=lliubbo@gmail.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.