All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] MAX6642 chip detection and other stuff
Date: Sat, 28 May 2011 14:04:36 +0000	[thread overview]
Message-ID: <20110528140436.GB10805@ericsson.com> (raw)
In-Reply-To: <20110528045113.GA8833@ericsson.com>

Hi Jean,

On Sat, May 28, 2011 at 04:36:31AM -0400, Jean Delvare wrote:
> Hi Guenter,
> 
> On Fri, 27 May 2011 21:51:13 -0700, Guenter Roeck wrote:
> > The attached patch (on top of Per's most recent patch) works quite nicely.
> > Per, maybe you can just merge it with your patch and resubmit it.
> 
> Looks good, pretty much what I had in mind. But I think you could make
> the code even more compact:
> 
> 	/* sanity check */
> 	if (i2c_smbus_read_byte_data(client, 0x04) != 0x4D
> 	 || i2c_smbus_read_byte_data(client, 0x06) != 0x4D
> 	 || i2c_smbus_read_byte_data(client, 0xff) != 0x4D)
> 		return -ENODEV;
> 
Yes, you are right. I didn't do it to avoid a checkpatch warning, but forgot
that I don't use a variable anymore.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-05-28 14:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-28  4:51 [lm-sensors] MAX6642 chip detection and other stuff Guenter Roeck
2011-05-28  8:36 ` Jean Delvare
2011-05-28 14:04 ` Guenter Roeck [this message]
2011-06-01  6:44 ` Per Dalén
2011-06-01  7:42 ` Per Dalén
2011-06-01  9:47 ` Jean Delvare
2011-06-01 15:38 ` Guenter Roeck
2011-06-01 15:43 ` Guenter Roeck
2011-06-04 17:29 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110528140436.GB10805@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.