All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Stubbs <jasonbstubbs@gmail.com>
To: Keith Packard <keithp@keithp.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: fix regression after clock gating init split
Date: Sat, 28 May 2011 14:26:28 +1000	[thread overview]
Message-ID: <201105281426.28488.jasonbstubbs@gmail.com> (raw)
In-Reply-To: <yunaae8j5dg.fsf@aiko.keithp.com>

On Sat, 28 May 2011 05:44:11 Keith Packard wrote:
> On Fri, 27 May 2011 23:44:19 +1000, Jason Stubbs <jasonbstubbs@gmail.com> 
wrote:
> > From: Jason Stubbs <jasonbstubbs@gmail.com>
> > 
> > However, there are some code paths, notably IS_PINEVIEW(dev), where 
> > init_clock_gating is not set and not needed.
> 
> Looks like Pineview should be using the gen3_init_clock_gating function.

Yep, you are right. Adding printk()s to the original implementation confirmed 
that - at least on my hardware. I should have known to check that...

There are two other code paths where an init_clock_gating function isn't 
specified though. The specific code paths are:

HAS_PCH_SPLIT() && !IS_GEN5() && !IS_GEN6() && !IS_IVYBRIDGE()

Looking at the original intel_enable_clock_gating() function, there would
have been some intialization done for this case.

IS_GEN4() && !IS_CRESTLINE() && !IS_BROADWATER()

It looks like this would have gone into the final "no gating match" if/else 
branch.

If both of the above don't happen in the real world, then I guess it's fine as 
is. If either are possible, then they need to be fixed too.

I'll just (re)send a patch for the IS_PINEVIEW() case and leave the above to
somebody who knows better than I...

Regards,
Jason Stubbs

  reply	other threads:[~2011-05-28  4:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27 13:44 [PATCH] drm/i915: fix regression after clock gating init split Jason Stubbs
2011-05-27 19:44 ` Keith Packard
2011-05-28  4:26   ` Jason Stubbs [this message]
2011-05-31 16:57     ` Jesse Barnes
2011-05-28  4:26   ` Jason Stubbs
2011-05-31 16:58     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105281426.28488.jasonbstubbs@gmail.com \
    --to=jasonbstubbs@gmail.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.