All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] jbd: fix a bug of leaking jh->b_jcount
Date: Mon, 30 May 2011 12:32:01 +0200	[thread overview]
Message-ID: <20110530103201.GB4075@quack.suse.cz> (raw)
In-Reply-To: <1306376941-13349-1-git-send-email-dingdinghua@nrchpc.ac.cn>

On Thu 26-05-11 10:29:01, Ding Dinghua wrote:
> journal_get_create_access should drop jh->b_jcount in error handling path
> 
> Signed-off-by: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
  Thanks. Merged into my tree.


								Honza
> ---
>  fs/jbd/transaction.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index f7ee81a..3b3b01f 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -844,8 +844,8 @@ int journal_get_create_access(handle_t *handle, struct buffer_head *bh)
>  	 */
>  	JBUFFER_TRACE(jh, "cancelling revoke");
>  	journal_cancel_revoke(handle, jh);
> -	journal_put_journal_head(jh);
>  out:
> +	journal_put_journal_head(jh);
>  	return err;
>  }
>  
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2011-05-30 10:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26  2:29 [PATCH 2/2] jbd: fix a bug of leaking jh->b_jcount Ding Dinghua
2011-05-30 10:32 ` Jan Kara [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-05-25 10:20 [PATCH 2/2] Jbd: " Ding Dinghua
2011-05-25 11:37 ` Yongqiang Yang
2011-05-25 11:47   ` Yongqiang Yang
2011-05-25 13:48     ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110530103201.GB4075@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=dingdinghua@nrchpc.ac.cn \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.