From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Girdwood, Liam" <lrg@ti.com>,
"ABRAHAM, KISHON VIJAY" <kishon@ti.com>
Subject: Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time
Date: Tue, 31 May 2011 00:52:22 -0700 [thread overview]
Message-ID: <20110531075222.GM11352@atomide.com> (raw)
In-Reply-To: <20110518105923.ed6a87e9.jhnikula@gmail.com>
* Jarkko Nikula <jhnikula@gmail.com> [110518 00:54]:
> On Wed, 18 May 2011 08:52:07 +0300
> Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>
> > On Tuesday 17 May 2011 15:57:00 Tony Lindgren wrote:
> > > This file should be under drivers/ somewhere, can you
> > > guys please take care of that?
> >
> > Yeah, this has been discussed several times, and we have not reached agreement
> > where to move this very OMAP specific code.
> > One option was to move it under sound/soc/omap/ , since currently the only
> > user for mcbsp is audio.
> > But McBSP is really versatile beast, it can be used for other things (for
> > example it can handle SPI bus as well), so if we move it under ASoC, we are
> > going to limit/block other use of these pins.
> > We can not just cp arc/arm/plat-omap/mcbsp.c drivers/wherever...
> > If we do that, we need to move it under some framework, or create a new one
> > (bus driver?), which might be a bit tricky since we have special use of McBSP
> > from audio side, this does not really fit the bus mode. Other uses of McBSP
> > might be happy with the bus driver conversion, but we just do not have those.
> >
> > IMHO the only place we can move this is under sound/soc/omap/ , but who can
> > decide, that the McBSP can only be used for audio??
> >
> I think we would need some higher level abstraction for this McBSP use
> model where the lowest level driver (here OMAP McBSP) is just used to
> configure the serial interface and a layer on top of that takes care of
> DMA transfer and protocol like SPI, I2S, etc.
>
> Why higher level abstraction? It's not only OMAP that has a general
> purpose serial interface. Also TI DaVinci has similar called McBSP/ASP
> and how about other SoCs, probably? What I looked once the DaVinci
> McBSP/ASP it wasn't compatible with OMAP McBSP but made me thinking
> that if these differences can be handled by a generic API.
Yeah I think this is the way to go.
Tony
next prev parent reply other threads:[~2011-05-31 7:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 10:33 [PATCH] OMAP4: McBSP: Clear rx_irq at probe time Peter Ujfalusi
2011-05-17 12:29 ` Jarkko Nikula
2011-05-17 12:57 ` Tony Lindgren
2011-05-18 5:52 ` Peter Ujfalusi
2011-05-18 7:59 ` Jarkko Nikula
2011-05-31 7:52 ` Tony Lindgren [this message]
2011-05-18 12:39 ` Peter Ujfalusi
2011-05-31 7:57 ` Tony Lindgren
2011-06-08 7:51 ` Peter Ujfalusi
2011-06-13 13:35 ` Tony Lindgren
2011-06-14 11:19 ` Péter Ujfalusi
2011-06-14 12:05 ` Jarkko Nikula
2011-06-14 12:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531075222.GM11352@atomide.com \
--to=tony@atomide.com \
--cc=jhnikula@gmail.com \
--cc=kishon@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.