All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Avi Kivity <avi@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Subject: Re: [PATCH] kvm: Fix build warnings
Date: Tue, 31 May 2011 12:26:55 +0200	[thread overview]
Message-ID: <20110531102655.GC24172@elte.hu> (raw)
In-Reply-To: <4DE4A4E7.80503@redhat.com>


* Avi Kivity <avi@redhat.com> wrote:

> On 05/31/2011 10:38 AM, Ingo Molnar wrote:
> >* Borislav Petkov<bp@alien8.de>  wrote:
> >
> >>  +++ b/arch/x86/kvm/paging_tmpl.h
> >>  @@ -121,7 +121,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
> >>   				gva_t addr, u32 access)
> >>   {
> >>   	pt_element_t pte;
> >>  -	pt_element_t __user *ptep_user;
> >>  +	pt_element_t __user *uninitialized_var(ptep_user);
> >
> >Note that doing this is actually actively dangerous for two reasons.
> >
> >
> 
> <snip lots of good advice>
> 
> > Please fix it instead.
> 
> s/instead/in addition/; while all those changes are good, they are 
> much too large for 3.0.  Let's push the simple fix for 3.0 and 
> queue the bigger refactoring to 3.1.

Yeah, that's probably wise, this is a tricky function.

Thanks,

	Ingo

  parent reply	other threads:[~2011-05-31 10:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30  9:46 KVM build warnings Borislav Petkov
2011-05-30 10:14 ` Takuya Yoshikawa
2011-05-30 12:46   ` Borislav Petkov
2011-05-30 20:11     ` [PATCH] kvm: Fix " Borislav Petkov
2011-05-31  7:38       ` Ingo Molnar
2011-05-31  8:19         ` Takuya Yoshikawa
2011-05-31  8:20         ` Avi Kivity
2011-05-31  9:02           ` Borislav Petkov
2011-05-31 10:26           ` Ingo Molnar [this message]
2011-06-07  7:28             ` Borislav Petkov
2011-06-07  7:58               ` Avi Kivity
2011-06-07  7:58                 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110531102655.GC24172@elte.hu \
    --to=mingo@elte.hu \
    --cc=avi@redhat.com \
    --cc=bp@alien8.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=yoshikawa.takuya@oss.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.