From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] OMAP: don't trace functions called from sched_clock Date: Tue, 31 May 2011 04:49:35 -0700 Message-ID: <20110531114935.GY11352@atomide.com> References: <1304846514-15641-1-git-send-email-rabin@rab.in> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:62032 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754434Ab1EaLtj (ORCPT ); Tue, 31 May 2011 07:49:39 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rabin Vincent Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org * Rabin Vincent [110527 08:36]: > Tony, >=20 > On Sun, May 8, 2011 at 14:51, Rabin Vincent wrote: > > omap_readl() is used from the sched_clock() implementations and so = must > > be marked notrace to avoid recursion in ftrace. =C2=A0Same thing wi= th > > mpu_read() for OMAP1. We should rather ioremap the 32KSYNCT_BASE in omap_init_clocksource_32k and then use __raw_readl. That allows us to get rid of omap_read usage here and simplifies the code. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 31 May 2011 04:49:35 -0700 Subject: [PATCH] OMAP: don't trace functions called from sched_clock In-Reply-To: References: <1304846514-15641-1-git-send-email-rabin@rab.in> Message-ID: <20110531114935.GY11352@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Rabin Vincent [110527 08:36]: > Tony, > > On Sun, May 8, 2011 at 14:51, Rabin Vincent wrote: > > omap_readl() is used from the sched_clock() implementations and so must > > be marked notrace to avoid recursion in ftrace. ?Same thing with > > mpu_read() for OMAP1. We should rather ioremap the 32KSYNCT_BASE in omap_init_clocksource_32k and then use __raw_readl. That allows us to get rid of omap_read usage here and simplifies the code. Regards, Tony