All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tasslehoff Kjappfot <tasskjapp@gmail.com>
Cc: Igor Grinberg <grinberg@compulab.co.il>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] free rev gpios when they are read, so others can read them later
Date: Tue, 31 May 2011 05:01:33 -0700	[thread overview]
Message-ID: <20110531120133.GC11352@atomide.com> (raw)
In-Reply-To: <91831E5F-5654-4133-AADC-9C3D6B86A63E@gmail.com>

* Tasslehoff Kjappfot <tasskjapp@gmail.com> [110528 02:20]:
> Hi Igor.
> > 
> > To be consistent with the rest of the file,
> > can the white space here be "tabs" instead of spaces?
> > 
> > 
> > -- 
> > Regards,
> > Igor.
> > 
> 
> They can. New version attached. I'm don't know how to use git send-email to continue this thread with a comment to my patch, so it was done manually. Let me know if something else is less-than-optimal with my patches. Rookie contributor :)

Thanks applying to fixes with following description:

Free Beagle rev gpios when they are read, so others can read them later
 
Regards,

Tony

> Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
> ---
>  arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 3ff3a2c..54dbb7dd 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -106,6 +106,9 @@ static void __init omap3_beagle_init_rev(void)
>  	beagle_rev = gpio_get_value(171) | (gpio_get_value(172) << 1)
>  			| (gpio_get_value(173) << 2);
>  
> +	gpio_free_array(omap3_beagle_rev_gpios,
> +			ARRAY_SIZE(omap3_beagle_rev_gpios));
> +
>  	switch (beagle_rev) {
>  	case 7:
>  		printk(KERN_INFO "OMAP3 Beagle Rev: Ax/Bx\n");
> -- 
> 1.7.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2011-05-31 12:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1306438716-68265-1-git-send-email-tasskjapp@gmail.com>
2011-05-26 19:59 ` [PATCH] free rev gpios when they are read, so others can read them later Tasslehoff Kjappfot
2011-05-27 11:28   ` Igor Grinberg
2011-05-28  9:24     ` Tasslehoff Kjappfot
2011-05-31 12:01       ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110531120133.GC11352@atomide.com \
    --to=tony@atomide.com \
    --cc=grinberg@compulab.co.il \
    --cc=linux-omap@vger.kernel.org \
    --cc=tasskjapp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.