From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andi Kleen <andi@firstfloor.org>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, josef@redhat.com, agruen@linbit.com,
"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH 1/4] Cache xattr security drop check for write v2
Date: Tue, 31 May 2011 21:21:35 +0100 [thread overview]
Message-ID: <20110531202135.GP11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110531201834.GB27166@one.firstfloor.org>
On Tue, May 31, 2011 at 10:18:34PM +0200, Andi Kleen wrote:
> On Tue, May 31, 2011 at 09:07:50PM +0100, Al Viro wrote:
> > On Tue, May 31, 2011 at 07:42:26PM +0100, Steven Whitehouse wrote:
> >
> > > Yes, it should test for xattr too,
> >
> > Frankly, I suspect that the sanest way to handle that is this:
> > * new superblock flag - MS_NOSEC
> > * S_NOSEC is never set unless we have MS_NOSEC
> > * mount_bdev() sets it before calling fill_super callback.
> > * ocfs2 and fuse *clear* it in their fill_super
>
> gfs2 needs to clear it too (unless Steven's updated patch goes in too)
> Steven?
gfs2 doesn't use mount_bdev(), so there's nothing that would set it (we
never pass it set in flags - mount(2) clears all but user-settable bits).
next prev parent reply other threads:[~2011-05-31 20:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 15:25 [PATCH 1/4] Cache xattr security drop check for write v2 Andi Kleen
2011-05-28 15:25 ` [PATCH 2/4] EXT4: Set NOSEC flag early when there are no xattrs v2 Andi Kleen
2011-05-28 15:25 ` [PATCH 3/4] BTRFS: Set NOSEC early for btrfs v2 Andi Kleen
2011-05-28 15:25 ` [PATCH 4/4] XFS: Set NOSEC flag early when inode has no xattrs. v2 Andi Kleen
2011-05-31 13:51 ` [PATCH 1/4] Cache xattr security drop check for write v2 Steven Whitehouse
2011-05-31 18:06 ` Andi Kleen
2011-05-31 18:42 ` Steven Whitehouse
2011-05-31 20:07 ` Al Viro
2011-05-31 20:18 ` Andi Kleen
2011-05-31 20:21 ` Al Viro [this message]
2011-06-18 6:58 ` Marco Stornelli
2011-06-18 18:04 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531202135.GP11521@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=agruen@linbit.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.