From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 0/2] Kill decode_cache Date: Wed, 1 Jun 2011 15:47:18 +0300 Message-ID: <20110601124718.GF491@redhat.com> References: <1306931665-26507-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29354 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162036Ab1FAMrT (ORCPT ); Wed, 1 Jun 2011 08:47:19 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51ClJUP030812 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Jun 2011 08:47:19 -0400 Content-Disposition: inline In-Reply-To: <1306931665-26507-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jun 01, 2011 at 03:34:23PM +0300, Avi Kivity wrote: > This mostly mindless patchset folds decode_cache into its enclosing struct, > x86_emulate_context. The point is to remove tons of pointless > > struct decode_cache *c = &ctxt->decode; > > lines from the code, which contribute absolutely nothing. > Didn't we plan some day to have a cache of decoded instructions to skip decoding stage? Not all the fields currently in decode_cache belong there of course (regs, io_read, mem_read). > Avi Kivity (2): > KVM: x86 emulator: rename decode_cache::eip to _eip > KVM: x86 emulator: fold decode_cache into x86_emulate_ctxt > > arch/x86/include/asm/kvm_emulate.h | 46 +- > arch/x86/kvm/emulate.c | 1275 +++++++++++++++++------------------- > arch/x86/kvm/trace.h | 8 +- > arch/x86/kvm/x86.c | 47 +- > 4 files changed, 631 insertions(+), 745 deletions(-) > > -- > 1.7.5.3 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gleb.