From: Matthew Garrett <mjg59@srcf.ucam.org>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] dell-laptop: support synaptics touchpad led
Date: Wed, 1 Jun 2011 14:31:55 +0100 [thread overview]
Message-ID: <20110601133155.GA5215@srcf.ucam.org> (raw)
In-Reply-To: <1306917288-8531-1-git-send-email-acelan.kao@canonical.com>
On Wed, Jun 01, 2011 at 04:34:48PM +0800, AceLan Kao wrote:
> The TP-LOCK-LED would bright while TP-disablement.
> You can implement 97 command services routing of P/S2 device.
> Code like below:
> out 0x64,0x97 ;set 0x97 to command port;0x64 is command port
> out 0x60,0x01 ;set 0x01 to data port then make LED bright;0x60 is data port
> out 0x60,0x02 ;set 0x02 to data port then make LED dark
>
> Before you send the action to the port, you must make sure the Input buffer
> is empty (port 0x64).
NAK - you're sending commands to the touchpad. The code for that needs
to live in the touchpad driver, not dell-laptop (what happens if these
commands are sent to different types of touchpad?). The scancode needs
to be mapped to an appropriate keycode and userspace needs to tie them
together.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-06-01 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 8:34 [PATCH] dell-laptop: support synaptics touchpad led AceLan Kao
2011-06-01 13:31 ` Matthew Garrett [this message]
2011-06-02 1:30 ` AceLan Kao
2011-06-02 2:05 ` Chris Bagwell
2011-06-02 3:18 ` AceLan Kao
2011-06-02 2:23 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601133155.GA5215@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=acelan.kao@canonical.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.