From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Rajkumar Manoharan <rmanoharan@atheros.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/6] mac80211: stop queues before rate control updation
Date: Wed, 1 Jun 2011 14:58:59 -0400 [thread overview]
Message-ID: <20110601185859.GF2509@tuxdriver.com> (raw)
In-Reply-To: <1306823717.9366.3.camel@jlt3.sipsolutions.net>
On Tue, May 31, 2011 at 08:35:17AM +0200, Johannes Berg wrote:
> On Fri, 2011-05-20 at 17:52 +0530, Rajkumar Manoharan wrote:
> > Stop tx queues before updating rate control to ensure
> > proper rate selection. Otherwise packets can be transmitted
> > in 40 Mhz whereas hw is configured in HT20.
>
> Looks like I completely missed this since you hid it in an ath9k
> patchset. DON'T DO THAT.
>
> Anyway, John, please revert. This is completely useless. Not only is
> abusing the CSA stop reason a show-stopper, the whole patch is also just
> not right, it seems like a workaround around a rate control algorithm
> that isn't able to do an atomic HT change by itself. Also, it won't even
> do what you want, there may be packets being processed concurrently
> while stopping the queue -- calling stop_queues() is no guarantee that
> no packet will be processed afterwards.
Rajkumar, do you have an alternative fix to propose?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-06-01 19:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 12:22 [PATCH 1/6] ath9k: Reset chip on baseband hang Rajkumar Manoharan
2011-05-20 12:22 ` [PATCH 3/6] ath9k: Handle IBSS status changes in BSS_CHANGED_IBSS Rajkumar Manoharan
2011-05-20 12:22 ` [PATCH 4/6] ath9k_hw: disable phy restart on baseband panic caused by RXSM Rajkumar Manoharan
2011-05-20 12:22 ` [PATCH 5/6] ath9k: set 40 Mhz rate only if hw is configured in ht40 Rajkumar Manoharan
2011-05-20 12:22 ` [PATCH 6/6] mac80211: stop queues before rate control updation Rajkumar Manoharan
2011-05-31 6:35 ` Johannes Berg
2011-05-31 7:20 ` Adrian Chadd
2011-06-01 18:58 ` John W. Linville [this message]
2011-06-03 5:00 ` Manoharan, Rajkumar
2011-06-06 18:44 ` John W. Linville
2011-06-06 18:57 ` Johannes Berg
2011-06-07 8:39 ` Manoharan, Rajkumar
2011-06-07 18:05 ` John W. Linville
[not found] ` <1305894135-14036-2-git-send-email-rmanoharan@atheros.com>
2011-05-21 4:27 ` [PATCH 2/6] ath9k: Remove ATH9K_BEACON_PERIOD mask Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601185859.GF2509@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.