From: Kyungmin Park <kmpark@infradead.org>
To: linux-mtd@lists.infradead.org
Cc: m.szyprowski@samsung.com, dwmw2@infradead.org, dedekind1@gmail.com
Subject: [PATCH] mtd: OneNAND: Fix wrong subpage_sft at 4KiB pagesize
Date: Thu, 02 Jun 2011 15:48:32 +0900 [thread overview]
Message-ID: <20110602064832.GA7319@july> (raw)
From: Kyungmin Park <kyungmin.park@samsung.com>
There's no case to use the subpage for 4KiB pagesize.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index ac9e959..337be7c 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -4047,13 +4047,11 @@ int onenand_scan(struct mtd_info *mtd, int maxchips)
*/
switch (mtd->oobsize) {
case 128:
- if (FLEXONENAND(this)) {
+ if (FLEXONENAND(this))
this->ecclayout = &flexonenand_oob_128;
- mtd->subpage_sft = 0;
- } else {
+ else
this->ecclayout = &onenand_oob_128;
- mtd->subpage_sft = 2;
- }
+ mtd->subpage_sft = 0;
break;
case 64:
this->ecclayout = &onenand_oob_64;
next reply other threads:[~2011-06-02 6:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 6:48 Kyungmin Park [this message]
2011-06-03 15:41 ` [PATCH] mtd: OneNAND: Fix wrong subpage_sft at 4KiB pagesize Artem Bityutskiy
2011-06-06 9:42 ` roman.tereshonkov
2011-06-06 10:02 ` Artem Bityutskiy
2011-06-06 10:06 ` Artem Bityutskiy
2011-06-06 23:55 ` Kyungmin Park
2011-06-07 9:54 ` roman.tereshonkov
2011-06-07 10:10 ` Kyungmin Park
2011-06-08 0:59 ` Kyungmin Park
2011-06-08 10:53 ` Artem Bityutskiy
2011-06-08 13:26 ` Kyungmin Park
2011-06-08 9:56 ` roman.tereshonkov
2011-06-08 10:04 ` Kyungmin Park
2011-06-08 10:20 ` roman.tereshonkov
2011-06-08 10:27 ` Kyungmin Park
2011-06-08 10:37 ` roman.tereshonkov
2011-06-03 15:58 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110602064832.GA7319@july \
--to=kmpark@infradead.org \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.