From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Thu, 02 Jun 2011 17:54:09 +0000 Subject: Re: sh: fix wrong icache/dcache address-array start addr in cache-debugfs. Message-Id: <20110602175409.GB26101@linux-sh.org> List-Id: References: <4DE76654.40605@st.com> In-Reply-To: <4DE76654.40605@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Thu, Jun 02, 2011 at 11:30:44AM +0100, Srinivas KANDAGATLA wrote: > This patch fixes a icache/dcache address-array start address while > dumping its entires in debugfs. Perviously the code was attempting to > remember the address in static variable, which is no more required > for debugfs, as the function can be executed in one pass. > If the assertion that we can now do this in one pass is true then certainly killing of the complexity/brokenness of caching the array can be dropped. It's been many years since I wrote that code so I have absolutely no recollection of the re-entry case, but it was necessary at the time. Has something changed in debugfs or the seq file interface that I'm unaware of that suddenly makes everything doable in a single pass? Also, what cache configurations have you tested this with? Our common case is 4-way set associative 32kB dcache, which if memory serves was already enough to overrun whatever debugfs had handy (I suppose a 4k page, as with procfs).