From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Arun Sharma <asharma@fb.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] Add an unresolved symbol for deleted binaries
Date: Thu, 2 Jun 2011 16:24:27 -0300 [thread overview]
Message-ID: <20110602192427.GC21739@ghostprotocols.net> (raw)
In-Reply-To: <20110602192249.GB21739@ghostprotocols.net>
Em Thu, Jun 02, 2011 at 04:22:49PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Jun 02, 2011 at 04:20:18PM -0300, Arnaldo Carvalho de Melo escreveu:
> > The first patch is fine (dso->deleted) and I applied it, thanks.
>
> oops, it has a problem as well, we can't set ->deleted when we just
> didn't found a symtab (stripped binary) fixing that.
oops, also we were setting it in map__load _after_ calling dso__load
that assumes it was already set, fixing that as well.
- Arnaldo
next prev parent reply other threads:[~2011-06-02 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 1:03 [PATCH] Add an unresolved symbol for deleted binaries Arun Sharma
2011-06-02 19:20 ` Arnaldo Carvalho de Melo
2011-06-02 19:22 ` Arnaldo Carvalho de Melo
2011-06-02 19:24 ` Arnaldo Carvalho de Melo [this message]
2011-06-03 9:21 ` Not able to profile a 64bit application Kumar Ranjit-B04060
2011-06-03 15:35 ` Arnaldo Carvalho de Melo
2011-06-13 4:21 ` Kumar Ranjit-B04060
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110602192427.GC21739@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=asharma@fb.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.