From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: bitbake-devel@lists.openembedded.org, Joshua Lock <josh@linux.intel.com>
Subject: Re: [RFC PATCH 1/2] bitbake: track skipped packages
Date: Fri, 3 Jun 2011 10:51:12 +0100 [thread overview]
Message-ID: <201106031051.12212.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <1307044917.2050.15.camel@scimitar>
On Thursday 02 June 2011 21:01:52 Joshua Lock wrote:
> This doesn't seem very Pythonic. I think you should just be able to do:
> bb.data.setVar("__SKIPPED", e, d)
> or possibly:
> bb.data.setVar("__SKIPPED", str(e), d)
Why is accessing args[0] un-Pythonic? As I understand it, args is provided
(and documented) as the way to get access to the arguments to the exception,
and the first argument is being used by us for the reason in the case of
SkipPackage. At the moment e or str(e) will accomplish the same thing, but
were we to add another argument then it seems to me that the results would be
different.
Now I'm not a Python expert by any stretch of the imagination but I'd like to
understand the reason why this usage might be considered undesirable.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-06-03 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 17:26 [RFC PATCH 0/2] skipped recipe handling Paul Eggleton
2011-06-01 17:26 ` [RFC PATCH 1/2] bitbake: track skipped packages Paul Eggleton
2011-06-02 20:01 ` Joshua Lock
2011-06-03 9:51 ` Paul Eggleton [this message]
2011-06-03 16:38 ` Joshua Lock
2011-06-01 17:26 ` [RFC PATCH 2/2] bitbake-layers: handle skipped recipes Paul Eggleton
2011-06-02 20:03 ` Joshua Lock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106031051.12212.paul.eggleton@linux.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=josh@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.