All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wei <jiaweiwei.xiyou@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: keithp@keithp.com, airlied@linux.ie,
	dri-devel@lists.freedesktop.org, greg@kroah.com,
	akpm@linux-foundation.org
Subject: [PATCH]remove warning for drivers/gpu/drm/i915/intel_ringbuffer.c
Date: Fri, 3 Jun 2011 21:09:39 +0800	[thread overview]
Message-ID: <20110603130502.GA5740@gmail.com> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 1356 bytes --]

From: Harry Wei <harryxiyou@gmail.com>
When i compile kernel, it shows me two warnings
like below, so this patch can fix them. 

[...]
CC [M]  drivers/gpu/drm/i915/intel_dvo.o
CC [M]  drivers/gpu/drm/i915/intel_ringbuffer.o
drivers/gpu/drm/i915/intel_ringbuffer.c:603: warning: ���ring_get_irq��� defined but not used
drivers/gpu/drm/i915/intel_ringbuffer.c:620: warning: ���ring_put_irq��� defined but not used
CC [M]  drivers/gpu/drm/i915/intel_overlay.o
CC [M]  drivers/gpu/drm/i915/intel_opregion.o
[...]


Signed-off-by: Harry Wei <harryxiyou@gmail.com>

Index: prj/drivers/gpu/drm/i915/intel_ringbuffer.c
===================================================================
--- prj.orig/drivers/gpu/drm/i915/intel_ringbuffer.c	2011-06-03 20:37:35.523539547 +0800
+++ prj/drivers/gpu/drm/i915/intel_ringbuffer.c	2011-06-03 20:38:07.279539574 +0800
@@ -599,23 +599,6 @@
 	return 0;
 }
 
-static bool
-ring_get_irq(struct intel_ring_buffer *ring, u32 flag)
-{
-	struct drm_device *dev = ring->dev;
-	drm_i915_private_t *dev_priv = dev->dev_private;
-
-	if (!dev->irq_enabled)
-	       return false;
-
-	spin_lock(&ring->irq_lock);
-	if (ring->irq_refcount++ == 0)
-		ironlake_enable_irq(dev_priv, flag);
-	spin_unlock(&ring->irq_lock);
-
-	return true;
-}
-
 static void
 ring_put_irq(struct intel_ring_buffer *ring, u32 flag)
 {

             reply	other threads:[~2011-06-03 13:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-03 13:09 Harry Wei [this message]
2011-06-03 17:36 ` [PATCH]remove warning for drivers/gpu/drm/i915/intel_ringbuffer.c Keith Packard
2011-06-04  2:41   ` Harry Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110603130502.GA5740@gmail.com \
    --to=jiaweiwei.xiyou@gmail.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=greg@kroah.com \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.