All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH-v3 1/2] tcg: Fix unused-but-set-variable warning
Date: Fri, 3 Jun 2011 18:35:59 +0200	[thread overview]
Message-ID: <20110603163559.GA14583@volta.aurel32.net> (raw)
In-Reply-To: <1306828429-9139-2-git-send-email-cfergeau@redhat.com>

On Tue, May 31, 2011 at 09:53:48AM +0200, Christophe Fergeau wrote:
> Based on a patch from Hans de Goede <hdegoede@redhat.com>
> 
> This warning is new in gcc 4.6.
> 
> Acked-by: Amit Shah <amit.shah@redhat.com>
> Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
> ---
>  tcg/tcg.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.

> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index 8748c05..e53b54c 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -585,7 +585,7 @@ void tcg_register_helper(void *func, const char *name)
>  void tcg_gen_callN(TCGContext *s, TCGv_ptr func, unsigned int flags,
>                     int sizemask, TCGArg ret, int nargs, TCGArg *args)
>  {
> -#ifdef TCG_TARGET_I386
> +#if defined(TCG_TARGET_I386) && TCG_TARGET_REG_BITS < 64
>      int call_type;
>  #endif
>      int i;
> @@ -612,7 +612,7 @@ void tcg_gen_callN(TCGContext *s, TCGv_ptr func, unsigned int flags,
>  
>      *gen_opc_ptr++ = INDEX_op_call;
>      nparam = gen_opparam_ptr++;
> -#ifdef TCG_TARGET_I386
> +#if defined(TCG_TARGET_I386) && TCG_TARGET_REG_BITS < 64
>      call_type = (flags & TCG_CALL_TYPE_MASK);
>  #endif
>      if (ret != TCG_CALL_DUMMY_ARG) {
> -- 
> 1.7.5.2
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

  reply	other threads:[~2011-06-03 16:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03 11:03 [Qemu-devel] [PATCH] Fix a number of unused-but-set-variable warnings (new with gcc-4.6) Hans de Goede
2011-05-17 11:25 ` Christophe Fergeau
2011-05-17 17:51   ` Aurelien Jarno
2011-05-27 10:34 ` Amit Shah
2011-05-30 10:28   ` [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings Christophe Fergeau
2011-05-30 10:28     ` [Qemu-devel] [PATCH 1/2] tcg: Fix unused-but-set-variable warning Christophe Fergeau
2011-05-30 10:28     ` [Qemu-devel] [PATCH 2/2] kvm: " Christophe Fergeau
2011-05-30 10:53     ` [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings Amit Shah
2011-05-30 13:56       ` Christophe Fergeau
2011-05-31  5:43         ` Amit Shah
2011-05-31  7:53           ` [Qemu-devel] [PATCH-v3 " Christophe Fergeau
2011-05-31  7:53             ` [Qemu-devel] [PATCH-v3 1/2] tcg: Fix unused-but-set-variable warning Christophe Fergeau
2011-06-03 16:35               ` Aurelien Jarno [this message]
2011-05-31  7:53             ` [Qemu-devel] [PATCH-v3 2/2] kvm: " Christophe Fergeau
2011-06-10 10:43               ` Christophe Fergeau
2011-06-10 12:17                 ` [Qemu-trivial] " Stefan Hajnoczi
2011-06-10 12:17                   ` Stefan Hajnoczi
2011-06-10 18:46               ` Stefan Hajnoczi
2011-06-11  7:46                 ` Jan Kiszka
2011-06-11 13:06                   ` Stefan Hajnoczi
2011-06-14 19:50                     ` Christophe Fergeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110603163559.GA14583@volta.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=cfergeau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.