All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@kernel.org>
Cc: kvm@vger.kernel.org, Cyrill Gorcunov <gorcunov@gmail.com>,
	John Floren <john@jfloren.net>,
	Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH 3/3] kvm tools, ui: Add support for SDL framebuffer output target
Date: Fri, 3 Jun 2011 18:58:05 +0200	[thread overview]
Message-ID: <20110603165805.GA19247@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.1106031954300.807@tiger>


* Pekka Enberg <penberg@kernel.org> wrote:

> On Fri, 3 Jun 2011, Ingo Molnar wrote:
> >it would be better to display a meaningful error message in that case
> >and not run, the user very likely has added --sdl expecting a
> >framebuffer to pop up!
> 
> Is this better?
> 
> penberg@tiger:~/linux/tools/kvm$ ./kvm run --sdl -p "root=/dev/vda1"
> -d ~/images/debian_squeeze_amd64_standard.img
>   # kvm run -k ../../arch/x86/boot/bzImage -m 320 -c 2
>   Warning: Config tap device error. Are you root?
>   Fatal: SDL support not compiled in.

Yeah! I'd suggest such a wording:

    Fatal: SDL support not compiled in. (install the SDL-dev[el] package)

Thanks,

	Ingo

  reply	other threads:[~2011-06-03 16:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-03 15:59 [PATCH 1/3] kvm tools, ui: Add framebuffer infrastructure Pekka Enberg
2011-06-03 15:59 ` [PATCH 2/3] kvm tools, ui: Move VNC specific framebuffer code to ui/vnc.c Pekka Enberg
2011-06-03 15:59 ` [PATCH 3/3] kvm tools, ui: Add support for SDL framebuffer output target Pekka Enberg
2011-06-03 16:26   ` Ingo Molnar
2011-06-03 16:28     ` Ingo Molnar
2011-06-03 16:33       ` Ingo Molnar
2011-06-03 16:37         ` Pekka Enberg
2011-06-03 16:40           ` Ingo Molnar
2011-06-03 16:44             ` Pekka Enberg
2011-06-03 16:45           ` Ingo Molnar
2011-06-03 16:46             ` Pekka Enberg
2011-06-03 16:52               ` Ingo Molnar
2011-06-03 16:54                 ` Pekka Enberg
2011-06-03 16:58                   ` Ingo Molnar [this message]
2011-06-03 16:54               ` Ingo Molnar
2011-06-03 16:56                 ` Ingo Molnar
2011-06-03 16:30     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110603165805.GA19247@elte.hu \
    --to=mingo@elte.hu \
    --cc=gorcunov@gmail.com \
    --cc=john@jfloren.net \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.