From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSc5x-0005yl-RJ for qemu-devel@nongnu.org; Fri, 03 Jun 2011 17:39:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSc5v-0002FD-HR for qemu-devel@nongnu.org; Fri, 03 Jun 2011 17:39:53 -0400 Received: from hall.aurel32.net ([88.191.126.93]:49897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSc5v-0002Ev-3b for qemu-devel@nongnu.org; Fri, 03 Jun 2011 17:39:51 -0400 Date: Fri, 3 Jun 2011 23:39:45 +0200 From: Aurelien Jarno Message-ID: <20110603213945.GG14583@volta.aurel32.net> References: <1304799829-19555-1-git-send-email-weil@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1304799829-19555-1-git-send-email-weil@mail.berlios.de> Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Venkateswararao Jujjuri , QEMU Developers On Sat, May 07, 2011 at 10:23:49PM +0200, Stefan Weil wrote: > cppcheck report: > virtio-9p.c:197: warning: Redundant assignment of "flags" to itself > > Cc: Venkateswararao Jujjuri > Signed-off-by: Stefan Weil > --- > hw/9pfs/virtio-9p.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Thanks, applied. > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > index ac5a1d0..d31b34a 100644 > --- a/hw/9pfs/virtio-9p.c > +++ b/hw/9pfs/virtio-9p.c > @@ -194,7 +194,6 @@ static int v9fs_do_open2(V9fsState *s, char *fullname, uid_t uid, gid_t gid, > cred.fc_uid = uid; > cred.fc_gid = gid; > cred.fc_mode = mode & 07777; > - flags = flags; > > return s->ops->open2(&s->ctx, fullname, flags, &cred); > } > -- > 1.7.2.5 > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net