From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p54E8xgj084161 for ; Sat, 4 Jun 2011 09:09:01 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2A370D76435 for ; Sat, 4 Jun 2011 07:08:56 -0700 (PDT) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id 7lxQCNFvstscwyG3 for ; Sat, 04 Jun 2011 07:08:56 -0700 (PDT) Date: Sat, 4 Jun 2011 10:08:48 -0400 From: Christoph Hellwig Subject: Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure Message-ID: <20110604140848.GA20404@infradead.org> References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-9-git-send-email-david@fromorbit.com> <20110604004231.GV11521@ZenIV.linux.org.uk> <20110604015212.GD561@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110604015212.GD561@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com, Al Viro , linux-kernel@vger.kernel.org On Sat, Jun 04, 2011 at 11:52:12AM +1000, Dave Chinner wrote: > I wanted to put it early on in the unmount path so that the shrinker > was guaranteed to be gone before evict_inodes() was called. That > would mean that it is obviously safe to remove the iprune_sem > serialisation in that function. The iprune_sem removal is fine as soon as you have a per-sb shrinker for the inodes which keeps an active reference on the superblock until all the inodes are evicted. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756713Ab1FDOI5 (ORCPT ); Sat, 4 Jun 2011 10:08:57 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:49627 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754891Ab1FDOIz (ORCPT ); Sat, 4 Jun 2011 10:08:55 -0400 Date: Sat, 4 Jun 2011 10:08:48 -0400 From: Christoph Hellwig To: Dave Chinner Cc: Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com Subject: Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure Message-ID: <20110604140848.GA20404@infradead.org> References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-9-git-send-email-david@fromorbit.com> <20110604004231.GV11521@ZenIV.linux.org.uk> <20110604015212.GD561@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110604015212.GD561@dastard> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 04, 2011 at 11:52:12AM +1000, Dave Chinner wrote: > I wanted to put it early on in the unmount path so that the shrinker > was guaranteed to be gone before evict_inodes() was called. That > would mean that it is obviously safe to remove the iprune_sem > serialisation in that function. The iprune_sem removal is fine as soon as you have a per-sb shrinker for the inodes which keeps an active reference on the superblock until all the inodes are evicted. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure Date: Sat, 4 Jun 2011 10:08:48 -0400 Message-ID: <20110604140848.GA20404@infradead.org> References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-9-git-send-email-david@fromorbit.com> <20110604004231.GV11521@ZenIV.linux.org.uk> <20110604015212.GD561@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com To: Dave Chinner Return-path: Content-Disposition: inline In-Reply-To: <20110604015212.GD561@dastard> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Jun 04, 2011 at 11:52:12AM +1000, Dave Chinner wrote: > I wanted to put it early on in the unmount path so that the shrinker > was guaranteed to be gone before evict_inodes() was called. That > would mean that it is obviously safe to remove the iprune_sem > serialisation in that function. The iprune_sem removal is fine as soon as you have a per-sb shrinker for the inodes which keeps an active reference on the superblock until all the inodes are evicted. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org