diff for duplicates of <20110604165757.GA19677@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index 82c6583..cd4279d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -32,7 +32,7 @@ On Sat, Jun 04, 2011 at 12:32:01PM -0400, Stijn Devriendt (sdevrien) wrote: > > > > + if (data->flags & LM90_HAVE_LOCAL_EXT) { > > + data->reg_local_ext = lm90_params[data->kind].reg_local_ext; -> > + BUG_ON(data->reg_local_ext = 0); +> > + BUG_ON(data->reg_local_ext == 0); > > + } > > + > > I think this BUG_ON is too harsh in probe.We generally use pr_err @@ -50,8 +50,3 @@ Maybe use WARN_ON instead ? Thanks, Guenter - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index d905c35..acc61e9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\0BANLkTimKB8PtFF72rOeDAmkbM_oq=ZMRgg@mail.gmail.com\0" "ref\06E4D2678AC543844917CA081C9D6B33F049B1DE3@XMB-AMS-103.cisco.com\0" "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" - "Subject\0Re: [lm-sensors] [PATCH] Add support for the Philips SA56004\0" - "Date\0Sat, 04 Jun 2011 16:57:57 +0000\0" + "Subject\0Re: [PATCH] Add support for the Philips SA56004 temperature sensor.\0" + "Date\0Sat, 4 Jun 2011 09:57:57 -0700\0" "To\0Stijn Devriendt (sdevrien) <sdevrien@cisco.com>\0" "Cc\0anish singh <anish198519851985@gmail.com>" khali@linux-fr.org <khali@linux-fr.org> @@ -45,7 +45,7 @@ "> >\n" "> > + \302\240 \302\240 \302\240 if (data->flags & LM90_HAVE_LOCAL_EXT) {\n" "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 data->reg_local_ext = lm90_params[data->kind].reg_local_ext;\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 BUG_ON(data->reg_local_ext = 0);\n" + "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 BUG_ON(data->reg_local_ext == 0);\n" "> > + \302\240 \302\240 \302\240 }\n" "> > +\n" "> > I think this BUG_ON is too harsh in probe.We generally use pr_err\n" @@ -62,11 +62,6 @@ "Maybe use WARN_ON instead ?\n" "\n" "Thanks,\n" - "Guenter\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + Guenter -7bffccb268919e019175876912006fe89879b48e309754cdd88c65e6e8aef828 +b9dda60060939a24c64d5a0ff31e08d83c0ff08186c8c0844a7a838e883b6a1f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.