From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH] spi: reorganize drivers Date: Sun, 5 Jun 2011 10:54:58 +0300 Message-ID: <20110605075458.GA2712@tarshish> References: <20110605071725.26517.11573.stgit@ponder> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jassi Brar Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Hi Jassi, On Sun, Jun 05, 2011 at 01:13:28PM +0530, Jassi Brar wrote: > On Sun, Jun 5, 2011 at 12:48 PM, Grant Likely wrote: > > [repost: I had a typo on the spi-devel-general mailing list address] > > > > Sort the SPI makefile and enforce the naming convention spi_*.c for > > spi drivers. [snip] > Though the spi_ prefix seems redundant considering the files are in > 'spi' directory. > Just a thought, no objection. When looking at the list of loaded modules (e.g. in an Oops message), the name "spi_xilinx" is much more meaningful than just "xilinx", for example. baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il - ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755561Ab1FEImC (ORCPT ); Sun, 5 Jun 2011 04:42:02 -0400 Received: from tango.tkos.co.il ([62.219.50.35]:35807 "EHLO tango.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753184Ab1FEImA (ORCPT ); Sun, 5 Jun 2011 04:42:00 -0400 X-Greylist: delayed 2785 seconds by postgrey-1.27 at vger.kernel.org; Sun, 05 Jun 2011 04:41:59 EDT Date: Sun, 5 Jun 2011 10:54:58 +0300 From: Baruch Siach To: Jassi Brar Cc: Grant Likely , spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: reorganize drivers Message-ID: <20110605075458.GA2712@tarshish> References: <20110605071725.26517.11573.stgit@ponder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jassi, On Sun, Jun 05, 2011 at 01:13:28PM +0530, Jassi Brar wrote: > On Sun, Jun 5, 2011 at 12:48 PM, Grant Likely wrote: > > [repost: I had a typo on the spi-devel-general mailing list address] > > > > Sort the SPI makefile and enforce the naming convention spi_*.c for > > spi drivers. [snip] > Though the spi_ prefix seems redundant considering the files are in > 'spi' directory. > Just a thought, no objection. When looking at the list of loaded modules (e.g. in an Oops message), the name "spi_xilinx" is much more meaningful than just "xilinx", for example. baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -