Re: sh: fix wrong icache/dcache address-array start addr in cache-debugfs.

[Paul Mundt <lethal@linux-sh.org>]

On Fri, Jun 03, 2011 at 02:42:09PM +0100, Srinivas KANDAGATLA wrote:
> Hi Paul,
> My comments are in-lined.
> Paul Mundt wrote:
> >On Thu, Jun 02, 2011 at 11:30:44AM +0100, Srinivas KANDAGATLA wrote:
> >>This patch fixes a icache/dcache address-array start address while
> >>dumping its entires in debugfs. Perviously the code was attempting to
> >>remember the address in static variable, which is no more required
> >>for debugfs, as the function can be executed in one pass.
> >>
> >If the assertion that we can now do this in one pass is true then
> >certainly killing of the complexity/brokenness of caching the array can
> >be dropped. It's been many years since I wrote that code so I have
> >absolutely no recollection of the re-entry case, but it was necessary at
> >the time. 
> Could be that, the existing code was carried from non-seq_file style 
> interface (proc read...).

That sounds like the most probable case.

> >Also, what cache configurations have you tested this with? Our common
> >case is 4-way set associative 32kB dcache, which if memory serves was
> >already enough to overrun whatever debugfs had handy (I suppose a 4k
> >page, as with procfs).
> I did test on 2Way cache with 32KB icache/dcache system.
> Original issue is not do with overrun, but incorrect results in virtual 
> file.
> 
Good enough for me. Applied, thanks.