All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: anish <anish198519851985@gmail.com>
Cc: jic23@cam.ac.uk, manuel.stahl@iis.fraunhofer.de,
	lucas.demarchi@profusion.mobi, arnd@arndb.de,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.
Date: Mon, 6 Jun 2011 14:55:49 -0700	[thread overview]
Message-ID: <20110606215549.GA7543@suse.de> (raw)
In-Reply-To: <1307387257.4327.12.camel@anish-desktop>

On Tue, Jun 07, 2011 at 12:37:37AM +0530, anish wrote:
> From: anish kumar <anish198519851985@gmail.com>
> 
> Replace kmalloc with local variables as it was un-necessary and
> also removed the redudant code after this change.

No, it was necessary, you just broke this driver on ARM-based systems,
which isn't nice at all :(

SPI data, like USB data, has to come from kmalloced data, not from the
stack, or bad things can, and will, happen.

So I can't accept this patch, sorry.

greg k-h

  parent reply	other threads:[~2011-06-06 21:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 19:07 [PATCH 1/2] staging: iio replaced kmalloc with local variables anish
2011-06-06 19:13 ` Geert Uytterhoeven
2011-06-06 19:49   ` Dan Carpenter
2011-06-06 19:20 ` Peter Hüwe
2011-06-06 21:55 ` Greg KH [this message]
2011-06-06 22:10   ` Joe Perches
2011-06-06 22:21     ` Greg KH
2011-06-06 22:28       ` Joe Perches
2011-06-06 22:41         ` Greg KH
2011-06-06 22:49           ` Joe Perches
     [not found]           ` <BANLkTimZP1=tOdsn9eNiERr0Up0xHrr=3g@mail.gmail.com>
2011-06-07  9:43             ` Jonathan Cameron
2011-06-07 10:32               ` anish kumar
2011-06-07 11:23                 ` Jonathan Cameron
2011-06-07  9:35     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110606215549.GA7543@suse.de \
    --to=gregkh@suse.de \
    --cc=anish198519851985@gmail.com \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=jic23@cam.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=manuel.stahl@iis.fraunhofer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.