From: Josh Triplett <josh@joshtriplett.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Sam Ravnborg <sam@ravnborg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCHv4] Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options
Date: Mon, 6 Jun 2011 15:08:10 -0700 [thread overview]
Message-ID: <20110606220810.GA1999@leaf> (raw)
In-Reply-To: <20110606183939.GA2335@leaf>
Several debugging options currently default to y, such as
CONFIG_DEBUG_BUGVERBOSE and CONFIG_DEBUG_RODATA. Embedded users might
want to turn those options off to save space; however, turning them off
requires turning on CONFIG_DEBUG_KERNEL to unhide them. Since
CONFIG_DEBUG_KERNEL exists specifically to unhide debugging options, and
CONFIG_EXPERT exists specifically to unhide options potentially needed
by experts and/or embedded users, make CONFIG_EXPERT automatically imply
CONFIG_DEBUG_KERNEL.
Since EXPERT now implies DEBUG_KERNEL, change debugging options that
reference DEBUG_KERNEL && EXPERT to just reference EXPERT.
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
v4: Avoid semantic changes, by changing DEBUG_KERNEL && EXPERT to EXPERT
rather than to DEBUG_KERNEL. This avoids exposing debug options that
only experts should turn off, such as DEBUG_BUGVERBOSE.
A subsequent patch should probably go through and change the various
"default !EXPERT" lines to "default y", since enabling CONFIG_EXPERT
should not directly change anything.
arch/tile/Kconfig.debug | 2 +-
init/Kconfig | 2 ++
lib/Kconfig.debug | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/tile/Kconfig.debug b/arch/tile/Kconfig.debug
index ddbfc33..1d31246 100644
--- a/arch/tile/Kconfig.debug
+++ b/arch/tile/Kconfig.debug
@@ -3,7 +3,7 @@ menu "Kernel hacking"
source "lib/Kconfig.debug"
config EARLY_PRINTK
- bool "Early printk" if EXPERT && DEBUG_KERNEL
+ bool "Early printk" if EXPERT
default y
help
Write kernel log output directly via the hypervisor console.
diff --git a/init/Kconfig b/init/Kconfig
index ebafac4..14370d3 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -909,6 +909,8 @@ config ANON_INODES
menuconfig EXPERT
bool "Configure standard kernel features (expert users)"
+ # Unhide debug options, to make the on-by-default options visible
+ select DEBUG_KERNEL
help
This option allows certain base kernel options and settings
to be disabled or tweaked. This is for specialized
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index dd373c8..9a00361 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -694,7 +694,7 @@ config DEBUG_HIGHMEM
Disable for production systems.
config DEBUG_BUGVERBOSE
- bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL && EXPERT
+ bool "Verbose BUG() reporting (adds 70K)" if EXPERT
depends on BUG
depends on ARM || AVR32 || M32R || M68K || SPARC32 || SPARC64 || \
FRV || SUPERH || GENERIC_BUG || BLACKFIN || MN10300 || TILE
--
1.7.5.3
next prev parent reply other threads:[~2011-06-06 22:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 21:02 [PATCH] Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options Josh Triplett
2011-06-05 21:31 ` Frederic Weisbecker
2011-06-06 1:23 ` [PATCHv2] " Josh Triplett
2011-06-06 22:06 ` [tip:core/debug] debug: " tip-bot for Josh Triplett
2011-06-06 15:18 ` [PATCH] " Ingo Molnar
2011-06-06 16:51 ` [PATCHv3] " Josh Triplett
2011-06-06 18:16 ` Frederic Weisbecker
2011-06-06 18:39 ` Josh Triplett
2011-06-06 21:34 ` Frederic Weisbecker
2011-06-06 22:02 ` Ingo Molnar
2011-06-06 22:08 ` Josh Triplett [this message]
2011-06-06 23:48 ` [PATCHv4] " Frederic Weisbecker
2011-06-06 21:39 ` [tip:core/debug] debug: " tip-bot for Josh Triplett
2011-06-06 21:45 ` Frederic Weisbecker
2011-06-06 22:09 ` Josh Triplett
2011-06-07 10:18 ` Ingo Molnar
2011-06-07 15:34 ` Josh Triplett
2011-06-07 18:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606220810.GA1999@leaf \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.