From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model Date: Tue, 7 Jun 2011 20:16:26 +0800 Message-ID: <20110607121626.GA2880@limbo> References: <20110607064842.GA8281@limbo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Tue, Jun 07, 2011 at 12:52:03PM +0100, Stefano Stabellini wrote: > On Tue, 7 Jun 2011, Wei Liu wrote: > > commit 6c744543757f0769e5a8f49ab0d8a01538357fbb > > Author: Wei Liu > > Date: Tue Jun 7 14:26:34 2011 +0800 > > > > libxl: use '-name' instead of deprecated '-domain-name' for device model. > > > > This unifies upstream qemu and Xen's qemu-dm startup option. > > > > Signed-off-by: Wei Liu > > > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > > index 47a51c8..d53a20d 100644 > > --- a/tools/libxl/libxl_dm.c > > +++ b/tools/libxl/libxl_dm.c > > @@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc, > > "-d", libxl__sprintf(gc, "%d", info->domid), NULL); > > > > if (info->dom_name) > > - flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL); > > + flexarray_vappend(dm_args, "-name", info->dom_name, NULL); > > > > if (info->vnc) { > > char *vncarg; > > considering that libxl__build_device_model_args_old is only meant to be > used with the old qemu-xen that we are not going to upgrade anymore, I > don't think it is worth to try to update its command line options. Well, device_model_{override,version} are not working for pure pv. I consider this patch a workaround for using upstream qemu as pure pv backend. I hope that IanJ's re-factoring of libxl will get a better implementation of this.