From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Rajeev Kumar <rajeev-dlh.kumar@st.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH V4 3/5] sound: asoc: Adding support for SPEAr13XX ASoC machine driver
Date: Tue, 7 Jun 2011 15:16:45 +0100 [thread overview]
Message-ID: <20110607141645.GG18544@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1307339856-30656-4-git-send-email-rajeev-dlh.kumar@st.com>
On Mon, Jun 06, 2011 at 11:27:34AM +0530, Rajeev Kumar wrote:
> +static struct platform_driver evb_driver = {
> + .driver = {
> + .name = "sta529",
This isn't a good name for the driver - the name should reflect the
board. This looks like it should be a driver for the CODEC.
next prev parent reply other threads:[~2011-06-07 14:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 5:57 [PATCH V4 0/5] Adding ASoC drivers for SPEAr13XX platform Rajeev Kumar
2011-06-06 5:57 ` [PATCH V4 1/5] sound: asoc: Adding support for STA529 Audio Codec Rajeev Kumar
2011-06-06 5:57 ` [PATCH V4 2/5] sound: asoc: Adding support for SPEAr13XX ASoC platform driver Rajeev Kumar
2011-06-06 5:57 ` [PATCH V4 3/5] sound: asoc: Adding support for SPEAr13XX ASoC machine driver Rajeev Kumar
2011-06-06 5:57 ` [PATCH V4 4/5] sound: asoc: Adding Kconfig and Makefile to support SPEAr13XX ASoC driver Rajeev Kumar
2011-06-06 5:57 ` [PATCH V4 5/5] sound: asoc: Adding support for SPEAr13XX in soc Rajeev Kumar
2011-06-07 14:17 ` [PATCH V4 4/5] sound: asoc: Adding Kconfig and Makefile to support SPEAr13XX ASoC driver Mark Brown
2011-06-07 14:16 ` Mark Brown [this message]
2011-06-07 14:12 ` [PATCH V4 2/5] sound: asoc: Adding support for SPEAr13XX ASoC platform driver Mark Brown
2011-06-08 9:05 ` Liam Girdwood
2011-06-06 6:23 ` [PATCH V4 1/5] sound: asoc: Adding support for STA529 Audio Codec Lars-Peter Clausen
2011-06-06 7:08 ` rajeev
2011-06-06 7:35 ` Lars-Peter Clausen
2011-06-06 10:19 ` rajeev
2011-06-07 7:06 ` Lars-Peter Clausen
2011-06-06 11:55 ` Mark Brown
2011-06-07 6:08 ` rajeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607141645.GG18544@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=rajeev-dlh.kumar@st.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.