From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: [PATCH 2/3] kprobes/trace: Fix kprobe selftest for gcc 4.6
Date: Tue, 07 Jun 2011 13:07:42 -0400 [thread overview]
Message-ID: <20110607170827.295368694@goodmis.org> (raw)
In-Reply-To: 20110607170740.235441001@goodmis.org
[-- Attachment #1: 0002-kprobes-trace-Fix-kprobe-selftest-for-gcc-4.6.patch --]
[-- Type: text/plain, Size: 1269 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
With gcc 4.6, the self test kprobe function:
kprobe_trace_selftest_target()
is optimized such that kallsyms does not list it. The kprobes
test uses this function to insert a probe and test it. But
it will fail the test if the function is not listed in kallsyms.
Because the name is rather unique, converting it from static to
global should not be a problem. This prevents gcc from removing
it from kallsyms.
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_kprobe.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index f925c45..2c14378 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -1870,8 +1870,12 @@ fs_initcall(init_kprobe_trace);
#ifdef CONFIG_FTRACE_STARTUP_TEST
-static int kprobe_trace_selftest_target(int a1, int a2, int a3,
- int a4, int a5, int a6)
+/*
+ * Can't be static, otherwise gcc might optimize this to
+ * not be in the kallsyms table.
+ */
+int kprobe_trace_selftest_target(int a1, int a2, int a3,
+ int a4, int a5, int a6)
{
return a1 + a2 + a3 + a4 + a5 + a6;
}
--
1.7.4.4
next prev parent reply other threads:[~2011-06-07 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 17:07 [PATCH 0/3] [GIT PULL][v3.0] tracing: fixes Steven Rostedt
2011-06-07 17:07 ` [PATCH 1/3] ftrace: Fix possible undefined return code Steven Rostedt
2011-06-07 17:07 ` Steven Rostedt [this message]
2011-06-07 18:08 ` [PATCH 2/3] kprobes/trace: Fix kprobe selftest for gcc 4.6 David Daney
2011-06-07 18:12 ` Steven Rostedt
2011-06-07 18:22 ` David Daney
2011-06-07 18:44 ` Steven Rostedt
2011-06-07 17:07 ` [PATCH 3/3] ftrace: Revert 8ab2b7efd ftrace: Remove unnecessary disabling of Steven Rostedt
2011-06-07 17:20 ` Richard W.M. Jones
2011-06-09 7:07 ` [PATCH 0/3] [GIT PULL][v3.0] tracing: fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607170827.295368694@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.