From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Andreas Dilger <adilger@whamcloud.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] mke2fs: Don't erase flash device if "-n" is given
Date: Tue, 7 Jun 2011 13:37:36 -0400 [thread overview]
Message-ID: <20110607173736.GC30037@thunk.org> (raw)
In-Reply-To: <4DEE58C0.3040303@redhat.com>
On Tue, Jun 07, 2011 at 11:58:40AM -0500, Eric Sandeen wrote:
> On 6/7/11 11:22 AM, Andreas Dilger wrote:
> > If "mke2fs -n" is used, there should be no changes to the underlying
> > device. Unfortunately, when the "discard" option was added in commit
> > c7cd908be59f48c66b4f3ac9a631ffe3dde4f1ab, it did not check for the "-n"
> > flag, and will discard all data on a flash device even if "-n" is given.
>
> Oh, crud.
I guess that means we should probably release e2fsprogs 1.41.15.
> > Check for the "noaction" flag before discarding any filesystem data.
> >
> > Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Added to the maint branch, thanks.
- Ted
prev parent reply other threads:[~2011-06-07 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 16:22 [PATCH] mke2fs: Don't erase flash device if "-n" is given Andreas Dilger
2011-06-07 16:58 ` Eric Sandeen
2011-06-07 17:37 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607173736.GC30037@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.