From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Robert Richter <robert.richter@amd.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [PATCH] x86: Make copy_from_user_nmi() a library function
Date: Wed, 8 Jun 2011 00:46:08 +0400 [thread overview]
Message-ID: <20110607204608.GA1754@sun> (raw)
In-Reply-To: <20110607172413.GJ20052@erda.amd.com>
On Tue, Jun 07, 2011 at 07:24:13PM +0200, Robert Richter wrote:
... (unrelated a bit) ...
> +
> + offset = addr & (PAGE_SIZE - 1);
> + size = min(PAGE_SIZE - offset, n - len);
> +
...
Robert, would not offset = addr & ~PAGE_MASK be somehow more
readable? Just a thought.
Cyrill
next prev parent reply other threads:[~2011-06-07 20:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <COL116-W380DF5357514E3CC28BB66A38F0@phx.gbl>
[not found] ` <4DD5046F.3000807@us.ibm.com>
[not found] ` <4DD53BC8.2010208@hotmail.com>
[not found] ` <20110607105259.GE20052@erda.amd.com>
[not found] ` <4DEE2F09.6090803@hotmail.com>
2011-06-07 17:18 ` [PATCH] oprofile, x86: Fix nmi-unsafe callgraph support in, 2.6.27 and later Robert Richter
2011-06-07 17:24 ` [RFC] [PATCH] x86: Make copy_from_user_nmi() a library function Robert Richter
2011-06-07 20:46 ` Cyrill Gorcunov [this message]
2011-07-05 17:22 ` Robert Richter
2011-07-05 17:40 ` Peter Zijlstra
2011-07-21 19:31 ` [tip:perf/core] x86, perf: " tip-bot for Robert Richter
[not found] ` <4DEFB4DC.7030206@hotmail.com>
2011-06-09 12:57 ` [PATCH] oprofile, x86: Fix nmi-unsafe callgraph support in, 2.6.27 and later Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607204608.GA1754@sun \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.