From: "J. Bruce Fields" <bfields@fieldses.org>
To: Pavel Shilovsky <piastryyy@gmail.com>
Cc: linux-nfs@vger.kernel.org,
Sean Finney <sean.finney@sonyericsson.com>,
Steve Dickson <steved@redhat.com>
Subject: Re: Regression in current master
Date: Tue, 7 Jun 2011 19:01:07 -0400 [thread overview]
Message-ID: <20110607230107.GD13911@fieldses.org> (raw)
In-Reply-To: <BANLkTinFR06gifZxx9f8Go2ngjm6TYNayw@mail.gmail.com>
On Wed, Jun 01, 2011 at 11:43:47AM +0400, Pavel Shilovsky wrote:
> Commit 9274e94db85bac04e170414cb8e0f4be271cde90
> (http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=9274e94db85bac04e170414cb8e0f4be271cde90)
> caused the regression when --manage-gids option is enabled: a user
> doesn't get group list through getgrouplist when auth_unix_gid is
> called twice. When I remove static attributes from gid_t *groups and
> int groups_len, it works good.
Looking at the patch....
Hm, I can't spot the bug. Sean?
(Also, not a correctness issue, but: shouldn't
if (rv == -1 && ngroups >= groups_len) {
be
if (rv == -1 && ngroups > groups_len) {
?
And, finally, why do we need the separate groups_len == 0 case at the
start at all? The realloc case should be able to handle the initial
case as well.
)
--b.
next prev parent reply other threads:[~2011-06-07 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 7:43 Regression in current master Pavel Shilovsky
2011-06-07 23:01 ` J. Bruce Fields [this message]
2011-06-07 23:03 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607230107.GD13911@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=piastryyy@gmail.com \
--cc=sean.finney@sonyericsson.com \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.