Re: [PATCH] qt-4.6.3: update qt's powervr graphics driver plugin to work with SGX DDK v1.6

[Denys Dmytriyenko <denis@denix.org>]

On Sun, Jun 05, 2011 at 06:52:24PM +0530, Balagopalakrishnan, Anand wrote:
> Can we include this patch in OpenEmbedded? This is a critical patch to 
> enable support for latest PowerVR drivers in Qt.
> 
> Regards,
> Anand

Anand,

Two comments:

1. When you move files around as [large] part of the patch, please use -M 
option for git-format-patch to avoid whole "remove-old-file-add-new-file". 
Below [1] is the example of how your re-applied patch looks like one-liner 
when generated with the above option.

2. Your MUA/MTA (Outlook/Exchange) mangled the patch, so it couldn't be 
applied anymore - I had to manually repeat the same steps to reproduce the 
patch. The problem was that in the original wsegl2-support patch there were 
some extra whitespaces, which got lost in the mail, as Outlook decided they 
were not needed... BTW, it wouldn't be a problem if you used -M option when 
creating the patch. Anyway, please consider sending patches directly using 
git-send-email or, if you absolutely cannot avoid Outlook/Exchange, please 
then attach them...

[1] Re-generated patch:

From e992a948b8a542e1f500342fca0a991f47bfbe9c Mon Sep 17 00:00:00 2001
From: Denys Dmytriyenko <denys@ti.com>
Date: Tue, 7 Jun 2011 21:54:58 -0400
Subject: [PATCH] qt-4.6.3: update qt's powervr graphics driver plugin to work with SGX DDK v1.6

* The wsegl2 patch is required to build Qt with the latest SGX PowerVR drivers
* Moved the wsegl2 patch from qt4/qt-4.7.3 to qt4/files
* Added the wsegl2 patch to qt-4.6.3

Note: This is the "massaged in" version of the original patch from Anand
Balagopalakrishnan <anandb@ti.com> as it was mangled and couldn't be applied.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 .../{qt-4.7.3 => files}/0001-wsegl2-support.patch  |    0
 recipes/qt4/qt-4.6.3.inc                           |    1 +
 2 files changed, 1 insertions(+), 0 deletions(-)
 rename recipes/qt4/{qt-4.7.3 => files}/0001-wsegl2-support.patch (100%)

diff --git a/recipes/qt4/qt-4.7.3/0001-wsegl2-support.patch b/recipes/qt4/files/0001-wsegl2-support.patch
similarity index 100%
rename from recipes/qt4/qt-4.7.3/0001-wsegl2-support.patch
rename to recipes/qt4/files/0001-wsegl2-support.patch
diff --git a/recipes/qt4/qt-4.6.3.inc b/recipes/qt4/qt-4.6.3.inc
index 36c6a56..1d5df70 100644
--- a/recipes/qt4/qt-4.6.3.inc
+++ b/recipes/qt4/qt-4.6.3.inc
@@ -15,6 +15,7 @@ SRC_URI = "ftp://ftp.trolltech.com/qt/source/qt-everywhere-opensource-src-${PV}.
            file://0010-no-simpledecoration-example.patch \
            file://fix-config-tests.patch \
            file://qt-config.patch \
+           file://0001-wsegl2-support.patch \
            file://g++.conf \
            file://linux.conf \
            "
-- 
1.7.0.4