All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/3] x86: Readd asmregparm
Date: Wed, 8 Jun 2011 10:19:57 +0200	[thread overview]
Message-ID: <20110608081957.GA14966@elte.hu> (raw)
In-Reply-To: <1307495401-2631-1-git-send-email-andi@firstfloor.org>


* Andi Kleen <andi@firstfloor.org> wrote:

> From: Andi Kleen <ak@linux.intel.com>
> 
> For a followon patchkit of mine I need to mark all functions
> that can be called from assembler. But on 32bit kernels some
> assembler functions are called with register arguments and others
> with stack arguments. asmlinkage forces stack arguments.
> 
> This patch readds the recently removed asmregparm to be able
> to mark assembler functions called with register arguments on 32bit.
> 
> Unlike the old code it's x86 only now to prevent it from
> leaking.
> 
> Cc: x86@kernel.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

That's a totally useless changelog (you are deliberately hiding 
information again) so the series is obviously not acceptable.
Please fix and resend.

Thanks,

	Ingo

  parent reply	other threads:[~2011-06-08  8:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08  1:09 [PATCH 1/3] x86: Readd asmregparm Andi Kleen
2011-06-08  1:10 ` [PATCH 2/3] x86: Add missing asmlinkages/asmregparm Andi Kleen
2011-06-08  1:10 ` [PATCH 3/3] x86: Change dotraplinkage into asmregparm for 32bit Andi Kleen
2011-06-08  8:19 ` Ingo Molnar [this message]
2011-06-08  8:37   ` [PATCH 1/3] x86: Readd asmregparm Andi Kleen
2011-06-08  8:53     ` Ingo Molnar
2011-06-08 11:57     ` Pekka Enberg
2011-06-08 12:28       ` Christoph Lameter
2011-06-08 16:01       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110608081957.GA14966@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.