From: Thomas Renninger <trenn@suse.de>
To: davej@codemonkey.org.uk
Cc: cpufreq@vger.kernel.org
Subject: [PATCH] cpufreq powernow-k8: Remove firmware warning in zero transition latency case
Date: Wed, 8 Jun 2011 10:07:13 +0200 [thread overview]
Message-ID: <201106081007.14264.trenn@suse.de> (raw)
AMD's BKDG documents that a zero transition latency should get passed for
several recent CPU models.
-> This isn't a firmware bug.
I did not dare to really pass the zero latency to the cpufreq core,
this would need careful checking whether this does not show side effects.
-> Still modify latency to 1 (us) in case BIOS passes zero.
Signed-off-by: Thomas Renninger <trenn@suse.de>
CC: cpufreq@vger.kernel.org
CC: davej@codemonkey.org.uk
---
drivers/cpufreq/powernow-k8.c | 13 ++-----------
1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
index 83479b6..170ad36 100644
--- a/drivers/cpufreq/powernow-k8.c
+++ b/drivers/cpufreq/powernow-k8.c
@@ -1022,18 +1022,9 @@ static int get_transition_latency(struct powernow_k8_data *data)
if (cur_latency > max_latency)
max_latency = cur_latency;
}
- if (max_latency == 0) {
- /*
- * Fam 11h and later may return 0 as transition latency. This
- * is intended and means "very fast". While cpufreq core and
- * governors currently can handle that gracefully, better set it
- * to 1 to avoid problems in the future.
- */
- if (boot_cpu_data.x86 < 0x11)
- printk(KERN_ERR FW_WARN PFX "Invalid zero transition "
- "latency\n");
+ if (max_latency == 0)
max_latency = 1;
- }
+
/* value in usecs, needs to be in nanoseconds */
return 1000 * max_latency;
}
next reply other threads:[~2011-06-08 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 8:07 Thomas Renninger [this message]
2011-06-08 13:55 ` [PATCH] cpufreq powernow-k8: Remove firmware warning in zero transition latency case Dave Jones
2011-06-08 14:46 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106081007.14264.trenn@suse.de \
--to=trenn@suse.de \
--cc=cpufreq@vger.kernel.org \
--cc=davej@codemonkey.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.