From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/1] ASoC: codecs: max98088: Combined DAI operations for DAI1 and DAI2. Date: Thu, 9 Jun 2011 20:07:28 +0100 Message-ID: <20110609190727.GC2821@opensource.wolfsonmicro.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 8959F103BF5 for ; Thu, 9 Jun 2011 21:07:29 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Hsiang Cc: "alsa-devel@alsa-project.org" , Jassi Brar , Jin Park , "lrg@slimlogic.co.uk" List-Id: alsa-devel@alsa-project.org On Thu, Jun 09, 2011 at 11:55:11AM -0700, Peter Hsiang wrote: > Mark, what's your thought on the use of id for this purpose here? > Would it be better to have 2 wrapper DAI functions passing in the DAI number? I think using the ids is fine; the ids originally come from the driver anyway - they're essentially private to it.