From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Eliad Peller <eliad@wizery.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add cancel_hw_scan() callback
Date: Fri, 10 Jun 2011 11:00:09 +0200 [thread overview]
Message-ID: <20110610090009.GA2503@redhat.com> (raw)
In-Reply-To: <1307691952-10980-1-git-send-email-eliad@wizery.com>
On Fri, Jun 10, 2011 at 10:45:52AM +0300, Eliad Peller wrote:
> When suspending, __ieee80211_suspend() calls ieee80211_scan_cancel(),
> which will only cancel sw scan. In order to cancel hw scan, the
> low-level driver has to cancel it in the suspend() callback. however,
> this is too late, as a new scan_work will be enqueued (while the driver
> is going into suspend).
>
> Add a new cancel_hw_scan() callback, asking the driver to cancel an
> active hw scan, and call it in ieee80211_scan_cancel().
Looks reasonable, but could you also update a comments?
> + /*
> + * The scan is canceled, but stop work from being pending.
Also this one is not valid and should be removed.
Stanislaw
next prev parent reply other threads:[~2011-06-10 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 7:45 [PATCH] mac80211: add cancel_hw_scan() callback Eliad Peller
2011-06-10 9:00 ` Stanislaw Gruszka [this message]
2011-06-10 13:00 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110610090009.GA2503@redhat.com \
--to=sgruszka@redhat.com \
--cc=eliad@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.