From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs Date: Fri, 10 Jun 2011 10:49:21 +0100 Message-ID: <20110610094920.GC26436@opensource.wolfsonmicro.com> References: <1307606950-8310-1-git-send-email-sbkim73@samsung.com> <1307606950-8310-4-git-send-email-sbkim73@samsung.com> <000a01cc273e$49dc4610$dd94d230$@com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Jassi Brar Cc: Sangbeom Kim , alsa-devel@alsa-project.org, kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org, lrg@slimlogic.co.uk List-Id: alsa-devel@alsa-project.org On Fri, Jun 10, 2011 at 12:56:45PM +0530, Jassi Brar wrote: > On Fri, Jun 10, 2011 at 12:46 PM, Sangbeom Kim wrote: > > I only focused on S5PV210 and S5PV310. > > I didn't consider s3c and s5p series. > > In the next version, I will delete it. > Though if then everything works fine with system and internal DMA, > maybe it is better to assign platform_name string at runtime from some > module parameter, and leaving the default to normal system DMA ? If iDMA is always a better choice on CPUs that support it then the cpu_is_() macros might be a good way to make the selection?