From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver Date: Fri, 10 Jun 2011 17:36:14 +0200 Message-ID: <201106101736.14850.arnd@arndb.de> References: <1307573154-15838-1-git-send-email-timur@freescale.com> <201106090938.23027.arnd@arndb.de> <4DF22770.4010103@tilera.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4DF22770.4010103@tilera.com> Sender: linux-console-owner@vger.kernel.org List-ID: Content-Type: Text/Plain; charset="us-ascii" To: Chris Metcalf Cc: linuxppc-dev@lists.ozlabs.org, Linux Virtualization , Randy Dunlap , Timur Tabi , konrad.wilk@oracle.com, kumar.gala@freescale.com, linux-kernel@vger.kernel.org, akpm@kernel.org, dsaxena@linaro.org, linux-console@vger.kernel.org, greg@kroah.com, alan@lxorguk.ukuu.org.uk On Friday 10 June 2011, Chris Metcalf wrote: > This still leaves open the question of what really should go in this new > directory. Is it just for drivers that manage/control the hypervisor? Or > is it also for drivers that just use the hypervisor to do I/O of some kind, > but aren't related to any other "family" of drivers, i.e., a driver that > would have been dumped in drivers/char or drivers/misc in the old days? > > My specific interest at the moment is the proposed tile-srom.c driver > (https://patchwork.kernel.org/patch/843892/), which uses a simple > hypervisor read/write API to access the portion of the SPI ROM used to hold > the boot stream for a TILE processor. I'd still put that driver in drivers/char for now, because it already contains similar drivers. We can probaby group them in a subdirectory of drivers/char at some point or move them out to a new directory. For your raw hcall passthrough driver, that would be something that should go into drivers/virt/ IMHO. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.10]) by ozlabs.org (Postfix) with ESMTP id 9E3F5B702F for ; Sat, 11 Jun 2011 01:36:24 +1000 (EST) From: Arnd Bergmann To: Chris Metcalf Subject: Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver Date: Fri, 10 Jun 2011 17:36:14 +0200 References: <1307573154-15838-1-git-send-email-timur@freescale.com> <201106090938.23027.arnd@arndb.de> <4DF22770.4010103@tilera.com> In-Reply-To: <4DF22770.4010103@tilera.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Message-Id: <201106101736.14850.arnd@arndb.de> Cc: Randy Dunlap , konrad.wilk@oracle.com, greg@kroah.com, kumar.gala@freescale.com, linux-kernel@vger.kernel.org, Linux Virtualization , dsaxena@linaro.org, linux-console@vger.kernel.org, akpm@kernel.org, linuxppc-dev@lists.ozlabs.org, Timur Tabi , alan@lxorguk.ukuu.org.uk List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Friday 10 June 2011, Chris Metcalf wrote: > This still leaves open the question of what really should go in this new > directory. Is it just for drivers that manage/control the hypervisor? Or > is it also for drivers that just use the hypervisor to do I/O of some kind, > but aren't related to any other "family" of drivers, i.e., a driver that > would have been dumped in drivers/char or drivers/misc in the old days? > > My specific interest at the moment is the proposed tile-srom.c driver > (https://patchwork.kernel.org/patch/843892/), which uses a simple > hypervisor read/write API to access the portion of the SPI ROM used to hold > the boot stream for a TILE processor. I'd still put that driver in drivers/char for now, because it already contains similar drivers. We can probaby group them in a subdirectory of drivers/char at some point or move them out to a new directory. For your raw hcall passthrough driver, that would be something that should go into drivers/virt/ IMHO. Arnd