From: Mika Westerberg <mika.westerberg@iki.fi>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
dan.j.williams@intel.com, vinod.koul@intel.com
Subject: Re: [PATCH] dma/ep93xx_dma.c: local symbols should be static
Date: Sat, 11 Jun 2011 08:47:51 +0300 [thread overview]
Message-ID: <20110611054751.GA2651@acer> (raw)
In-Reply-To: <201106101515.05990.hartleys@visionengravers.com>
On Fri, Jun 10, 2011 at 03:15:05PM -0700, H Hartley Sweeten wrote:
> The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver
> and should be marked static.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Mika Westerberg <mika.westerberg@iki.fi>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
>
> ---
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index 0766c1e..5d7a49b 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
> *
> * Returns a valid DMA descriptor or %NULL in case of failure.
> */
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
> ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
> dma_addr_t src, size_t len, unsigned long flags)
> {
next prev parent reply other threads:[~2011-06-11 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 22:15 [PATCH] dma/ep93xx_dma.c: local symbols should be static H Hartley Sweeten
2011-06-11 5:47 ` Mika Westerberg [this message]
2011-06-16 4:20 ` Koul, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110611054751.GA2651@acer \
--to=mika.westerberg@iki.fi \
--cc=dan.j.williams@intel.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.