All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian@openwrt.org>
To: Richard Weinberger <richard@nod.at>
Cc: nico@openwrt.org, user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH 2/2] um: disable compile-time buffer checks
Date: Mon, 13 Jun 2011 14:39:44 +0200	[thread overview]
Message-ID: <201106131439.44908.florian@openwrt.org> (raw)
In-Reply-To: <201106130056.12956.richard@nod.at>

Le lundi 13 juin 2011 00:56:12, Richard Weinberger a écrit :
> Am Sonntag 12 Juni 2011, 23:52:35 schrieb Florian Fainelli:
> > Le dimanche 12 juin 2011 13:56:14, Richard Weinberger a écrit :
> > > Am Sonntag 12 Juni 2011, 13:14:41 schrieb Florian Fainelli:
> > > > From: Nicolas Thill <nico@openwrt.org>
> > > > 
> > > > Ubuntu 8.10 and newer enable compile-time buffer checks by default,
> > > > 
> > > > which can sometime cause build failures like this:
> > > >   LD      vmlinux
> > > >   SYSMAP  System.map
> > > >   SYSMAP  .tmp_System.map
> > > >   LINK linux
> > > >   Building modules, stage 2.
> > > >   MODPOST 51 modules
> > > > 
> > > > ERROR: "__sprintf_chk" [arch/um/drivers/harddog.ko] undefined!
> > > 
> > > Hmm, now I'm wondering why no other Ubuntu users have noticed this.
> > > Are also current versions of Ubuntu affected?
> > 
> > Without this patch, I get the exact same modpost error on Ubuntu 11.04:
> Okay, found the real problem.
> We have to export the *_chk functions.
> Nobody noticed it because most UML kernels are CONFIG_MODULES=n
> and harddog.ko is not part of the defaultconfig.
> 
> Can you please test the attached patch?

Your patch works, thank you!

Feel free to add my Testbed-by: Florian Fainelli <florian@openwrt.org to the 
final patch.
--
Florian

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel


      reply	other threads:[~2011-06-13 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-12 11:14 [uml-devel] [PATCH 2/2] um: disable compile-time buffer checks Florian Fainelli
2011-06-12 11:56 ` Richard Weinberger
2011-06-12 21:52   ` Florian Fainelli
2011-06-12 22:56     ` Richard Weinberger
2011-06-13 12:39       ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106131439.44908.florian@openwrt.org \
    --to=florian@openwrt.org \
    --cc=nico@openwrt.org \
    --cc=richard@nod.at \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.