From: Sven Eckelmann <sven@narfation.org>
To: Antonio Quartulli <ordex@autistici.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] Combination of flags in tt_query packets
Date: Mon, 13 Jun 2011 16:30:51 +0200 [thread overview]
Message-ID: <201106131630.52328.sven@narfation.org> (raw)
In-Reply-To: <201106131629.19141.sven@narfation.org>
[-- Attachment #1: Type: Text/Plain, Size: 557 bytes --]
Sven Eckelmann wrote:
> Then you say that you don't use flags but 2 bits to store 2 values. Please
> don't use it in your code as flags, but use something like (x &
> TT_TYPE_MASK) to extract the corresponding bits and compare the resulting
> values against representation of TT_RESPONSE and TT_RESPONSE (TT_TYPE_MASK
> would be 0x3, TT_RESPONSE 0 and TT_REQUEST 3). Also remove the TT_RESPONSE
> and TT_REQUEST from the enum tt_query_flags and use another enum for them.
s/TT_REQUEST 3/TT_REQUEST 2/
1 and 3 are currently undefined.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-06-13 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 9:52 [B.A.T.M.A.N.] Combination of flags in tt_query packets Sven Eckelmann
2011-06-13 13:25 ` Antonio Quartulli
2011-06-13 14:29 ` Sven Eckelmann
2011-06-13 14:30 ` Sven Eckelmann [this message]
2011-06-13 17:02 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106131630.52328.sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=ordex@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.