All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v6] drivers/hwmon NTC Thermistor Initial
Date: Mon, 13 Jun 2011 17:06:15 +0000	[thread overview]
Message-ID: <20110613170615.GB2629@ericsson.com> (raw)
In-Reply-To: <1307949359-27587-1-git-send-email-dg77.kim@samsung.com>

On Mon, Jun 13, 2011 at 03:15:59AM -0400, Donggeun Kim wrote:
> This patch adds support for NTC Thermistor series. In this release, the
> following thermistors are supported: NCP15WB473, NCP18WB473, NCP03WB473,
> and NCP15WL333. This driver is based on the datasheet of MURATA.
> 
> The driver in the patch does conversion from the raw ADC value
> (either voltage or resistence) to temperature. In order to use
> voltage values as input, the circuit schematics should be provided
> with the platform data. A compensation table for each type of thermistor
> is provided for the conversion.
> 
> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
> Signed-off-by: MyungJoo Ham <myungjoo.kim@samsung.com>
> Signed-off-by: KyungMin Park <kyungmin.park@samsung.com>
> 
Hi folks,

Almost there.

[ ... ]

>  include/linux/ntc.h     |   53 ++++++

Please move this file to include/linux/platform_data/ntc.h.

One question, though: ntc.[ch] is quite high level and suggests a wider scope than just thermistors.
Would it make sense to use ntc_thermistor.[ch] instead ?

[ ... ]
> +       if ((data->mintemp != INT_MAX) || (data->maxtemp != INT_MIN)) {

The inner ( ) are unnecessary. Please remove.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2011-06-13 17:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-13  7:15 [lm-sensors] [PATCH v6] drivers/hwmon NTC Thermistor Initial Donggeun Kim
2011-06-13 17:06 ` Guenter Roeck [this message]
2011-06-14  2:25 ` MyungJoo Ham
2011-06-14  2:41 ` Donggeun Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110613170615.GB2629@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.