From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Maarten Lankhorst <m.b.lankhorst@gmail.com>
Cc: Yinghai Lu <yinghai@kernel.org>, Jim Bos <jim876@xs4all.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, efi: Do not reserve boot services regions within reserved areas
Date: Tue, 14 Jun 2011 16:21:02 +0100 [thread overview]
Message-ID: <20110614152101.GA17773@srcf.ucam.org> (raw)
In-Reply-To: <4DF77832.9020407@gmail.com>
On Tue, Jun 14, 2011 at 05:03:14PM +0200, Maarten Lankhorst wrote:
> + /* Could not reserve boot area */
> + if (!size)
> + continue;
> +
> + printk(KERN_INFO PFX "Freeing boot area "
> + "[0x%llx-0x%llx)\n", start, start+size);
Probably don't need the printk - we could be dumping a few hundred of
those.
> - "Kernel-defined memdesc doesn't match the one from EFI!\n");
> + "Kernel-defined memdesc (%lu) "
> + "doesn't match the one from EFI(%lu)!\n",
> + sizeof(efi_memory_desc_t), memmap.desc_size);
And drop this hunk. It's entirely valid for an implementation to do
this, we should just delete the message entirely.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-06-14 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 15:03 [PATCH] x86, efi: Do not reserve boot services regions within reserved areas Maarten Lankhorst
2011-06-14 15:21 ` Matthew Garrett [this message]
2011-06-14 15:31 ` Maarten Lankhorst
2011-06-14 15:53 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614152101.GA17773@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jim876@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=m.b.lankhorst@gmail.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.