All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v7] drivers/hwmon NTC Thermistor Initial
Date: Tue, 14 Jun 2011 18:39:17 +0000	[thread overview]
Message-ID: <20110614183917.GA7613@ericsson.com> (raw)
In-Reply-To: <1308029766-3254-1-git-send-email-dg77.kim@samsung.com>

On Tue, Jun 14, 2011 at 01:36:06AM -0400, Donggeun Kim wrote:
> This patch adds support for NTC Thermistor series. In this release, the
> following thermistors are supported: NCP15WB473, NCP18WB473, NCP03WB473,
> and NCP15WL333. This driver is based on the datasheet of MURATA.
> 
> The driver in the patch does conversion from the raw ADC value
> (either voltage or resistence) to temperature. In order to use
> voltage values as input, the circuit schematics should be provided
> with the platform data. A compensation table for each type of thermistor
> is provided for the conversion.
> 
> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: KyungMin Park <kyungmin.park@samsung.com>
> 
Hi,

Test compile resulted in:

drivers/hwmon/ntc_thermistor.c: In function ‘get_temp_mC’:
drivers/hwmon/ntc_thermistor.c:174: warning: ‘mid’ may be used uninitialized in this function
drivers/hwmon/ntc_thermistor.c:174: note: ‘mid’ was declared here

Please fix.

Also, please make the following changes:

- In Documentation/hwmon/ntc-thermistor, please list correct prefix values.
- Please add EXPERIMENTAL Kconfig dependency.
- Please change MODULE_ALIAS to "platform:ntc-thermistor".

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      reply	other threads:[~2011-06-14 18:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14  5:36 [lm-sensors] [PATCH v7] drivers/hwmon NTC Thermistor Initial Donggeun Kim
2011-06-14 18:39 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110614183917.GA7613@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.