From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: PATCH: s3c2410_udc: udc command always disables pull-up instead of passing the command Date: Tue, 14 Jun 2011 13:15:25 -0700 Message-ID: <20110614201525.GA16736@kroah.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out4.smtp.messagingengine.com ([66.111.4.28]:40227 "EHLO out4.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752929Ab1FNUWD (ORCPT ); Tue, 14 Jun 2011 16:22:03 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Skacore Systems Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org On Tue, Jun 14, 2011 at 12:07:19PM +0200, Skacore Systems wrote: > Hello *, > > There is a bug in s3c2410_udc driver, which triggers when using custom UDC > command for USB pull-up. > As a result driver is always calling user defined UDC command with wrong > parameter (S3C2410_UDC_P_DISABLE) instead of > just passing the parameter to the user defined function. > > BR. > > Vilo > Please take a look at Documentation/SubmittingPatches for how to properly send a patch that can be applied (hint, you need a Signed-off-by: line, a patch that can properly apply that doesn't have whitespace corruption or line wrapping.) thanks, greg k-h