All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arun Sharma <asharma@fb.com>
To: Sam Liao <phyomh@gmail.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [perf] fix annotation loading when symbol sort order not used.
Date: Tue, 14 Jun 2011 15:03:04 -0700	[thread overview]
Message-ID: <20110614220304.GA17101@dev1756.snc6.facebook.com> (raw)
In-Reply-To: <BANLkTinXzHiCTb6EWWGSJmzz5dS1P9p1sg@mail.gmail.com>

On Sun, Jun 12, 2011 at 02:09:40AM +0800, Sam Liao wrote:
> When "symbol" is not in "-s" sort order options, the hist entry's
> ms.sym is not equal to sample's addr_location.sym where we should
> not load annotation. This fix check if symbol sort order used, if
> not, disable symbol annonation for report command in tui mode.

Thanks for taking care of this. Works well for me.

 -Arun

      reply	other threads:[~2011-06-14 22:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-11 18:09 [PATCH] [perf] fix annotation loading when symbol sort order not used Sam Liao
2011-06-14 22:03 ` Arun Sharma [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110614220304.GA17101@dev1756.snc6.facebook.com \
    --to=asharma@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=phyomh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.