From: Tejun Heo <tj@kernel.org>
To: Maxin B John <maxin.john@gmail.com>
Cc: akpm@linux-foundation.org, segooon@gmail.com, jkosina@suse.cz,
tglx@linutronix.de, eike-kernel@sf-tec.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] devres: Fix possible use after free
Date: Wed, 15 Jun 2011 10:13:17 +0200 [thread overview]
Message-ID: <20110615081317.GL8141@htj.dyndns.org> (raw)
In-Reply-To: <BANLkTimHjVX6ymALT-ZBeSs1S+PRDRwQaQ@mail.gmail.com>
Hello, Maxin.
On Tue, Jun 14, 2011 at 03:09:34PM +0100, Maxin B John wrote:
> You are right. I shouldn't have mentioned it as dangerous. I was trying to
> make this patch description similar to the description present in the
> previous patch:
> http://www.spinics.net/lists/mm-commits/msg84313.html
>
> This patch silences the Coverity Prevent's complains about this as
> use-after-free bug. Please let me know if the updated patch description is OK.
>
> "
> A freed pointer is passed as an argument to the function "devres_destroy()" in
> "kernel/irq/devres.c" and "lib/devres.c". This patch fixes the possible use
> after free.
> The change silences the static analysis tool (Coverity Prevent) complains
> about this as use-after-free bug.
> "
Yeap, sounds mostly okay but there's no 'possible use after free'.
Maybe something like, "devres uses the pointer value as key after it's
freed, which is safe but triggers spurious use-after-free warnings on
some static analysis tools. Rearrange code to avoid such warnings".
Thanks.
--
tejun
next prev parent reply other threads:[~2011-06-15 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 7:07 [PATCH] [RESEND] devres: Fix possible use after free Maxin B John
2011-06-14 7:15 ` Tejun Heo
2011-06-14 14:09 ` Maxin B John
2011-06-15 8:13 ` Tejun Heo [this message]
2011-06-15 9:59 ` Maxin B John
2011-06-15 10:00 ` Rolf Eike Beer
2011-06-15 10:12 ` Maxin B John
-- strict thread matches above, loose matches on Subject: below --
2011-06-15 17:14 Maxin B John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110615081317.GL8141@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=eike-kernel@sf-tec.de \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=maxin.john@gmail.com \
--cc=segooon@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.